Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more models to the xml model registry #1474

Merged
merged 2 commits into from Jul 11, 2018
Merged

Add more models to the xml model registry #1474

merged 2 commits into from Jul 11, 2018

Conversation

facero
Copy link
Contributor

@facero facero commented Jul 10, 2018

Problems have been spotted concerning the spectral index definition in
ctools (-index and index). Need to think about a WCS frame attribute for
Skymodel. ExpcutoffPow has Ecut vs lambda. SkyPointSource evaluate
returns an empty array.

@facero
Added more Spatial and Spectral Models to the xml model_registry
c45fee5 
Problems have been spotted concerning the spectral index definition in
ctools (-index and index). Need to think about a WCS frame for
Skymodel. ExpcutoffPow has Ecut vs lambda. SkyPointSource evaluate
returns an empty array.
@facero
Copy link
Contributor Author

facero commented Jul 10, 2018 •
edited

@cdeil @joleroi plenty of material to discuss tomorrow
ctools definition: http://cta.irap.omp.eu/ctools/users/user_manual/models_spectral.html
gammapy: http://docs.gammapy.org/dev/api/gammapy.spectrum.models.PowerLaw.html#gammapy.spectrum.models.PowerLaw

@facero
Added handling for the index/-index for PowerLaw and Ecut->lambda
e423878 
added conversion and tests for PowerLaw and ExpCutoffPL to handle the
differences btw ctools and gammapy
@joleroi joleroi added this to In progress in gammapy.modeling via automation Jul 11, 2018
@joleroi joleroi self-requested a review July 11, 2018 12:21
@joleroi joleroi added this to the 0.8 milestone Jul 11, 2018
@joleroi joleroi changed the title Added more Spatial and Spectral Models to the xml model_registry Add more Spatial and Spectral Models to the xml model_registry Jul 11, 2018
@joleroi joleroi merged commit c255ddf into gammapy:master Jul 11, 2018
gammapy.modeling automation moved this from In progress to Done Jul 11, 2018
@facero facero deleted the read-xml-registry branch July 11, 2018 12:25
@cdeil cdeil changed the title Add more Spatial and Spectral Models to the xml model_registry Add more models to the xml model registry Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joleroi joleroi joleroi approved these changes

Assignees

@facero facero

Labels
feature
Projects
gammapy.modeling
  
Done
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@facero @joleroi