Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more models to the xml model registry #1474

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
2 participants
@facero
Copy link
Contributor

facero commented Jul 10, 2018

Problems have been spotted concerning the spectral index definition in
ctools (-index and index). Need to think about a WCS frame attribute for
Skymodel. ExpcutoffPow has Ecut vs lambda. SkyPointSource evaluate
returns an empty array.

Added more Spatial and Spectral Models to the xml model_registry
Problems have been spotted concerning the spectral index definition in
ctools (-index and index). Need to think about a WCS frame for
Skymodel. ExpcutoffPow has Ecut vs lambda. SkyPointSource evaluate
returns an empty array.
@facero

This comment has been minimized.

Copy link
Contributor Author

facero commented Jul 10, 2018

Added handling for the index/-index for PowerLaw and Ecut->lambda
added conversion and tests for PowerLaw and ExpCutoffPL to handle the
differences btw ctools and gammapy

@joleroi joleroi added the feature label Jul 11, 2018

@joleroi joleroi added this to In progress in Modeling via automation Jul 11, 2018

@joleroi joleroi self-requested a review Jul 11, 2018

@joleroi joleroi added this to the 0.8 milestone Jul 11, 2018

@joleroi joleroi changed the title Added more Spatial and Spectral Models to the xml model_registry Add more Spatial and Spectral Models to the xml model_registry Jul 11, 2018

@joleroi joleroi merged commit c255ddf into gammapy:master Jul 11, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Modeling automation moved this from In progress to Done Jul 11, 2018

@facero facero deleted the facero:read-xml-registry branch Jul 11, 2018

@cdeil cdeil changed the title Add more Spatial and Spectral Models to the xml model_registry Add more models to the xml model registry Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.