-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fermi PSF convolution method #154
Conversation
I'm not sure if the travis-ci failures are real or a fluke. |
offset_max = Angle(max_offset, 'deg') | ||
if energy == 'None': | ||
energy_band = Quantity(energy_band, 'GeV') | ||
fermi_psf = EnergyDependentTablePSF.read(filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should accept an EnergyDependentTablePSF
as input or be a method on that class.
The PSF you use here will only be correct for a given source class and change e.g. when PASS 8 comes out.
Plus we want to use the same PSF class e.g. for HESS and CTA and will need to use those as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that makes more sense. I will change this.
I didn't notice the errors before, but I get a lot now (I was originally going to make one pull request but then separated the commits out, so I probably screwed something up then). They all seem to relate to FermiGalacticCenter though, which isn't changed here: I'll try and fix this and make a pull request if there's some kind of bug e.g. here's an error message: ______________________________________ ERROR collecting gammapy/irf/tests/test_effective_area.py _______________________________________
|
Made changes, new pull request as implementation changed quite a bit: see #155 |
Fix unit of SCALE in PSF_3GAUSS, fixes gammapy#154
Adds method for fermi energy-dependent psf convolution in gammapy.image.