New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fermi PSF convolution method #154

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ellisowen
Contributor

ellisowen commented Jul 24, 2014

Adds method for fermi energy-dependent psf convolution in gammapy.image.

@cdeil

This comment has been minimized.

Member

cdeil commented Jul 24, 2014

I'm not sure if the travis-ci failures are real or a fluke.
Do tests pass for you locally?
Can you add a test and push a new commit to see if the travis-ci tests disappear?

offset_max = Angle(max_offset, 'deg')
if energy == 'None':
energy_band = Quantity(energy_band, 'GeV')
fermi_psf = EnergyDependentTablePSF.read(filename)

This comment has been minimized.

@cdeil

cdeil Jul 24, 2014

Member

This function should accept an EnergyDependentTablePSF as input or be a method on that class.

The PSF you use here will only be correct for a given source class and change e.g. when PASS 8 comes out.
Plus we want to use the same PSF class e.g. for HESS and CTA and will need to use those as well.

This comment has been minimized.

@ellisowen

ellisowen Jul 24, 2014

Contributor

OK, that makes more sense. I will change this.

@ellisowen

This comment has been minimized.

Contributor

ellisowen commented Jul 24, 2014

I didn't notice the errors before, but I get a lot now (I was originally going to make one pull request but then separated the commits out, so I probably screwed something up then). They all seem to relate to FermiGalacticCenter though, which isn't changed here:

I'll try and fix this and make a pull request if there's some kind of bug

e.g. here's an error message:

______________________________________ ERROR collecting gammapy/irf/tests/test_effective_area.py _______________________________________
gammapy/irf/tests/test_effective_area.py:10: in

from ...datasets import arf_fits_table
gammapy/datasets/init.py:5: in
from .load import *
gammapy/datasets/load.py:25: in
from ..spectral_cube import GammaSpectralCube
gammapy/spectral_cube/init.py:5: in
from .core import *
gammapy/spectral_cube/core.py:23: in
from ..image.utils import coordinates
gammapy/image/init.py:3: in
from .healpix import *
gammapy/image/healpix.py:11: in
from .utils import coordinates
gammapy/image/utils.py:11: in
from ..datasets import FermiGalacticCenter
E ImportError: cannot import name FermiGalacticCenter

@ellisowen

This comment has been minimized.

Contributor

ellisowen commented Jul 25, 2014

Made changes, new pull request as implementation changed quite a bit: see #155

@ellisowen ellisowen closed this Jul 25, 2014

@cdeil cdeil changed the title from Adds method to gammapy.image.utils for fermi psf convolution to Add Fermi PSF convolution method Apr 8, 2015

@cdeil cdeil added the feature label Apr 8, 2015

@cdeil cdeil added this to the 0.1 milestone Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment