Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite FluxpointEstimator #1929

Merged
merged 4 commits into from Nov 15, 2018
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Nov 15, 2018

This PR includes the following changes:

  • Introduce a spectral model ScaleModel, that allows to scale arbitrary other spectral models with a norm parameter
  • Rewrite the FluxPointEstimator to use this new ScaleModel
  • Adapt the FluxPointEstimator to recent changes in the Fit class API

In a follow up PR I will implement the computation of likelihood profiles for flux points.

@adonath adonath added this to the 0.9 milestone Nov 15, 2018
@adonath adonath self-assigned this Nov 15, 2018
@adonath adonath added this to To do in gammapy.makers via automation Nov 15, 2018
@adonath adonath merged commit 2164f37 into gammapy:master Nov 15, 2018
0 of 2 checks passed
0 of 2 checks passed
Scrutinizer Installing Code
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.makers automation moved this from To do to Done Nov 15, 2018
@adonath adonath deleted the adonath:rewrite_flux_point_estimator branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant