Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve field-of-view coordinate transformations #2009
Following discussion in #1987, this PR improves the field-of-view coordinate transformations by using astropy utilities, namely the
I've kept the old versions as comments, since the new ones are apparently much slower (in a very quick test I did). If performance ever becomes an issue (which is not so unlikely), we may want to consider to go back to the old transformations.
referenced this pull request
Jan 29, 2019
@lmohrmann - Thanks!
There's of course the question if we should implement FOV frame using astropy.coordinates directly. But this PR is a big step forward towards simpler code, so I'm merging this in now without further discussion.
Once we have a first caller / use of this functionality or two, we can improve further - suggestions or PRs welcome any time.
Jan 29, 2019
To follow up on the suggestions by @registerrier to use SkyCoord in the API:
@registerrier - I was also thinking about suggesting to use
@lmohrmann - is the code here in line with the definitions here? Maybe you could send a follow-up PR to add a link to the definition in the docstring, and if you want to introduce SkyCoord as input / output, do that? Would suggest to wait for @kosack to comment though to avoid changing back and forth.