Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop Python 2 support #2012
Here I only do the simple / obvious / partly automated changes. This will result in a large diff.
More specific changes that might require discussion (like e.g. using
Following the advice here, I've added
I think that's enough, raising errors in
Other changes in this PR:
This PR is ready. @adonath or anyone interested - I don't think there's anything that needs review or is controversial here, but if you want, have a look (review one commit at a time should be easy). I'll wait a few hours before merging.
I would suggest to keep #1963 for about another week and discuss / gather suggestions for non-trivial updates (like using ProcessPoolExecutor or keyword-only arguments) there. If anyone finds something that can be modernised or cleaned up in Gammapy now that we're Python 3.5+, or if there is a feature we could start using, please leave a comment there.