Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TablePSF class #2022

Merged
merged 5 commits into from Feb 6, 2019

Conversation

Projects
None yet
1 participant
@adonath
Copy link
Member

adonath commented Feb 5, 2019

This is a follow-up PR to #2019 and introduces the following changes:

  • Re-factor the TablePSFclass and remove the UnivariateSpline interpolation by replacing it with the ScaledRegularGridInterpolator from gammapy.utils.
  • Add bi-linear interpolation to EnergyDepdendentMultiGaussPSF
  • Fix the containment computation in TablePSF and EnergyDepdendentTablePSF, which was introduced incorrectly in #2019.

@adonath adonath requested a review from registerrier Feb 5, 2019

@adonath adonath self-assigned this Feb 5, 2019

@adonath adonath added this to the 0.11 milestone Feb 5, 2019

@adonath adonath force-pushed the adonath:remove_spline_interpolation branch from f4da583 to 5fb7620 Feb 6, 2019

@adonath adonath merged commit 77b276d into gammapy:master Feb 6, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 2 new issues, 8 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adonath adonath changed the title Re-factor TablePSF class Refactor TablePSF class Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.