Remove gammapy.extern.validator and validate_physical_type #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
gammapy.extern.validator. The only function from there that we used wasvalidate_physical_type. I replaced this with a call toQuantityinpsf_gauss.py, just like I already did forgammapy.astroearlier today in #2192 .This brings us towards internal consistency for quantity handling in Gammapy, we already were using
Quantity, notvalidate_physical_typein 99% of our code.I'm sure there are many places in Gammapy where we should improve unit and quantity handling. But I believe Astropy core has good solutions for this since many years, and a separate
gammapy.extern.validatoris not the way to go.Discussed offline with @adonath who agreed - so I'll merge this right away as a small cleanup PR without discussion.