Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets names follow up #2785

Merged
merged 5 commits into from Feb 21, 2020
Merged

Conversation

adonath
Copy link
Member

@adonath adonath commented Feb 20, 2020

Description

This pull request does some more clean up and adaption follow up work to #2782. The main changes included are:

  • Remove Dataset.parameters, as all parameters are now in Dataset.models.parameters
  • Remove the model section from the model setter and just select the right models in .npred() and .npred_sig()
  • An important change that comes with this is that BackgroundModel now needs to define the datasets_names to be evaluated for the given dataset. We might re-consider this before v0.17, but for now it works like this.

@adonath adonath self-assigned this Feb 20, 2020
@adonath adonath added this to the 0.17 milestone Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #2785 into master will decrease coverage by 0.03%.
The diff coverage is 79.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2785      +/-   ##
==========================================
- Coverage   92.23%   92.19%   -0.04%     
==========================================
  Files         144      144              
  Lines       16548    16544       -4     
==========================================
- Hits        15263    15253      -10     
- Misses       1285     1291       +6
Impacted Files Coverage Δ
gammapy/modeling/sampling.py 21.66% <0%> (ø) ⬆️
gammapy/time/lightcurve_estimator.py 96.1% <100%> (-0.1%) ⬇️
gammapy/cube/make.py 94.28% <100%> (ø) ⬆️
gammapy/cube/simulate.py 91.66% <100%> (ø) ⬆️
gammapy/modeling/datasets.py 86.33% <100%> (ø) ⬆️
gammapy/cube/fit.py 91.01% <100%> (-0.28%) ⬇️
gammapy/cube/fov.py 98% <100%> (ø) ⬆️
gammapy/spectrum/flux_point.py 93.19% <71.42%> (-0.26%) ⬇️
gammapy/spectrum/dataset.py 94.86% <72.22%> (-0.82%) ⬇️
gammapy/modeling/models/cube.py 91.69% <91.66%> (-0.06%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9cc8c...7320fd5. Read the comment docs.

@adonath adonath merged commit a03792c into gammapy:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant