Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify EBL absorption spectral model #3100

Merged
merged 2 commits into from Nov 2, 2020
Merged

Conversation

QRemy
Copy link
Contributor

@QRemy QRemy commented Nov 2, 2020

This PR simplify EBL absorption spectral model as proposed in PIG 21: #2944

This PR simplify EBL absorption spectral model as proposed in PIG 21: gammapy#2944
@QRemy QRemy requested a review from adonath November 2, 2020 14:24
@QRemy QRemy added the cleanup label Nov 2, 2020
@QRemy QRemy added this to In progress in gammapy.modeling via automation Nov 2, 2020
@QRemy QRemy added this to the 0.18 milestone Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #3100 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
+ Coverage   93.10%   93.11%   +0.01%     
==========================================
  Files         145      145              
  Lines       18020    17989      -31     
==========================================
- Hits        16777    16751      -26     
+ Misses       1243     1238       -5     
Impacted Files Coverage Δ
gammapy/modeling/models/__init__.py 100.00% <ø> (ø)
gammapy/modeling/models/spectral.py 96.86% <ø> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3b18b...f5fe8b4. Read the comment docs.

adonath
adonath previously approved these changes Nov 2, 2020
Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @QRemy, I have left two minor inline comments...

gammapy/modeling/models/spectral.py Outdated Show resolved Hide resolved
gammapy/modeling/models/spectral.py Show resolved Hide resolved
gammapy/modeling/models/spectral.py Show resolved Hide resolved
@adonath
Copy link
Member

adonath commented Nov 2, 2020

Thanks @QRemy!

@adonath adonath merged commit b49ff33 into gammapy:master Nov 2, 2020
gammapy.modeling automation moved this from In progress to Done Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants