Further improve model region / mask selection #3215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a follow-up to #3169. It further breaks down the functionality like so:
Map.mask_nearest_position()
, which returns the nearest position inside the mask to given positionIRFMap
. Right now it was using themask_safe_psf
for PSF as EDisp, however it's not guaranteed that those agree. For this is introduce aIRFMap.mask_safe_irf
, which derives the mask from the data. however we might think about moving the mask safe for the IRF to theIRFMap
completely, this would be more than convenient for stacking as well...RegionGeom.from_regions()
, which creates aRegionGeom
with aCompoundSkyRegion
from a list of regions, while working on this I think we should clarify the handling ofCompoundRegion
vs. a list ofRegion
, everywhere in Gammapy. I added it as a discussion point on the agenda for the dev call on Friday.Dear reviewer