Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FluxMaps in TSMapEstimator #3285

Merged
merged 12 commits into from
Apr 9, 2021

Conversation

adonath
Copy link
Member

@adonath adonath commented Mar 25, 2021

Description

This pull request implements the use of FluxMaps in the TSMapEstimator and adds the additional quantities defined in #3278.

  • For now I added support __getitem__ in FluxMaps for backwards compatibility with the dict of maps. Keep it?
  • Add FluxMaps.niter?
  • Add unit tests for additional quantities

@adonath adonath self-assigned this Mar 25, 2021
@adonath adonath added this to the v0.19 milestone Mar 25, 2021
@adonath adonath force-pushed the ts_map_estimator_quantities branch from 048a31d to b829da8 Compare April 9, 2021 16:01
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #3285 (b829da8) into master (acba5b5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.01%     
==========================================
  Files         144      144              
  Lines       17854    17857       +3     
==========================================
+ Hits        16747    16753       +6     
+ Misses       1107     1104       -3     
Impacted Files Coverage Δ
gammapy/estimators/core.py 94.79% <100.00%> (+1.85%) ⬆️
gammapy/estimators/flux_map.py 92.08% <100.00%> (ø)
gammapy/estimators/flux_point.py 92.94% <100.00%> (-0.03%) ⬇️
gammapy/estimators/ts_map.py 97.99% <100.00%> (-0.05%) ⬇️
gammapy/modeling/parameter.py 96.32% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acba5b5...b829da8. Read the comment docs.

@adonath adonath merged commit eeb15c9 into gammapy:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant