Fixed TS map boundary handling #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonath
force-pushed
the
fix_ts_boundary_handling
branch
from
f60a432
to
90b2f23
Compare
| @@ -5,8 +5,9 @@ | |||
| import json | |||
| import logging | |||
| log = logging.getLogger(__name__) | |||
| from ..utils.scripts import get_parser | |||
| from ..utils.scripts import get_parser, _configure_root_logger | |||
|
I left a few minor comments inline. Travis-ci passed, so this is almost ready to go. |
adonath
force-pushed
the
fix_ts_boundary_handling
branch
from
90b2f23
to
3cd22ea
Compare
adonath
force-pushed
the
fix_ts_boundary_handling
branch
from
3cd22ea
to
a751712
Compare
adonath
added a commit
that referenced
this pull request
Aug 25, 2015
Fixed TS map boundary handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the boundary behaviour of the TS map computation. I guess there's not much to review here. I will wait for the Travis-builds and then do the merge.