Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to Github repo #3656

Merged
merged 1 commit into from Nov 29, 2021
Merged

Add license to Github repo #3656

merged 1 commit into from Nov 29, 2021

Conversation

Bultako
Copy link
Member

@Bultako Bultako commented Nov 23, 2021

This PR adds LICENSE.rst at the root level so to make possible Zenodo syncing with Github, now failing with the following error.

{
"errors": "The license ID you have selected is not present in our system. For the available licenses please check in the following URL https://developers.zenodo.org/#licenses"
} 

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository

@adonath adonath self-assigned this Nov 23, 2021
@adonath
Copy link
Member

adonath commented Nov 23, 2021

I guess the 2nd question is whether the license file we have is compatible with any of the valid licenses...

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3656 (cc101cb) into master (d5d2e12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3656   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files         162      162           
  Lines       19507    19507           
=======================================
  Hits        18290    18290           
  Misses       1217     1217           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d2e12...cc101cb. Read the comment docs.

@Bultako
Copy link
Member Author

Bultako commented Nov 23, 2021

I have installed and run in my laptop licensee which is the tool used by Github to detect licenses from files, as it is said here

It seems that the license is well detected from the LICENSE.rst file.

~/git/gammapy/gammapy$ licensee detect .
License:        BSD-3-Clause
Matched files:  LICENSE.rst
LICENSE.rst:
  Content hash:  da0ec2854bfc396385cfc49501ed09e1a19b015b
  Attribution:   Copyright (c) 2014, Gammapy developers
  Confidence:    99.17%
  Matcher:       Licensee::Matchers::Dice
  License:       BSD-3-Clause
  Closest non-matching licenses:
    BSD-3-Clause similarity:        99.17%
    BSD-4-Clause similarity:        85.51%
    BSD-3-Clause-Clear similarity:  84.40%

@adonath adonath added this to the 1.0 milestone Nov 29, 2021
@adonath adonath added this to In progress in MAINTAIN via automation Nov 29, 2021
Copy link
Member

@adonath adonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bultako, no further comments from my side.

@adonath adonath merged commit ba0e5f7 into gammapy:master Nov 29, 2021
MAINTAIN automation moved this from In progress to Done Nov 29, 2021
@Bultako Bultako deleted the license branch November 29, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
MAINTAIN
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants