New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for files exported by H.E.S.S. #470
Conversation
FYI ignore changes to If we all agree on the general procedure I will expand this method to all IRFs |
Looks good to me. There's this travis-ci fail though: Can you reproduce and fix or should I have a look? |
You can have a look at |
That's a timeout that happened when installing the dependencies. I've restarted build 2038 just now by clicking the restart symbol at the top right here: If the error is still there I can have a look on what changed on the conda side. |
I don't think this is merely a timeout, after restarting the test it again fails when trying to update setuptools. I will try to fix it .. |
But you can't reproduce the issue on your machine, right? |
Wait, maybe I screwed up restarting the tests properly ... But anyway. Locally I don't have to download anything, right? |
Closing this now. I will update the other IRFs in a second PR next week |
Add test for files exported by H.E.S.S.
This PR introduces
gammapy/irf/tests/test_hess.py
The idea is the following
gammapy-extra/test_datasets/reference/make_reference_files
The tests of the functionality of the IRF classes remain in the old test files, e.g.
test_effective_area.py
. But here only the classes themselves are tested irrespective of real files. Optimally these test would work on simulated IRFs where we know extact numbers