Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate units in pcolormesh #4755

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

registerrier
Copy link
Contributor

Description

This pull request solves #4754 by applying pcolormesh on the values rather than the quantity object.

Dear reviewer

Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
@registerrier registerrier added this to the 1.2 milestone Sep 21, 2023
@registerrier registerrier added backport-v1.0.x on-merge: backport to v1.0.x backport-v1.1.x on-merge: backport to v1.1.x labels Sep 21, 2023
@registerrier
Copy link
Contributor Author

For compatibility this should be backported.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #4755 (e53e1ea) into main (1f1a57a) will increase coverage by 0.01%.
Report is 12 commits behind head on main.
The diff coverage is 88.57%.

@@            Coverage Diff             @@
##             main    #4755      +/-   ##
==========================================
+ Coverage   76.00%   76.02%   +0.01%     
==========================================
  Files         223      223              
  Lines       32019    32053      +34     
==========================================
+ Hits        24337    24367      +30     
- Misses       7682     7686       +4     
Files Changed Coverage Δ
gammapy/estimators/map/core.py 92.80% <69.23%> (-0.63%) ⬇️
gammapy/estimators/map/tests/test_core.py 96.76% <100.00%> (+0.21%) ⬆️
gammapy/irf/background.py 93.56% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@registerrier
Copy link
Contributor Author

During dev meeting, we agreed to keep a unit test to check for pcolormesh and Quantity. This will be in a future PR.

@registerrier registerrier merged commit 4009fc4 into gammapy:main Sep 22, 2023
15 checks passed
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 22, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v1.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4009fc4d6c99dbb955bedda76f5e4ae874f3a088
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #4755: Separate units in pcolormesh'
  1. Push to a named branch:
git push YOURFORK v1.0.x:auto-backport-of-pr-4755-on-v1.0.x
  1. Create a PR against branch v1.0.x, I would have named this PR:

"Backport PR #4755 on branch v1.0.x (Separate units in pcolormesh)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/gammapy that referenced this pull request Sep 22, 2023
registerrier added a commit to registerrier/gammapy that referenced this pull request Sep 22, 2023
registerrier added a commit that referenced this pull request Sep 25, 2023
…5-on-v1.1.x

Backport PR #4755 on branch v1.1.x (Separate units in pcolormesh)
registerrier added a commit that referenced this pull request Sep 25, 2023
…n-v1.0.x

Backport PR #4755: Separate units in pcolormesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1.0.x on-merge: backport to v1.0.x backport-v1.1.x on-merge: backport to v1.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants