-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate units in pcolormesh #4755
Conversation
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
For compatibility this should be backported. |
Codecov Report
@@ Coverage Diff @@
## main #4755 +/- ##
==========================================
+ Coverage 76.00% 76.02% +0.01%
==========================================
Files 223 223
Lines 32019 32053 +34
==========================================
+ Hits 24337 24367 +30
- Misses 7682 7686 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
During dev meeting, we agreed to keep a unit test to check for pcolormesh and Quantity. This will be in a future PR. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…5-on-v1.1.x Backport PR #4755 on branch v1.1.x (Separate units in pcolormesh)
…n-v1.0.x Backport PR #4755: Separate units in pcolormesh
Description
This pull request solves #4754 by applying
pcolormesh
on the values rather than the quantity object.Dear reviewer