-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate name to avoid starting with underscore #4761
Conversation
Signed-off-by: <quentin.remy@live.fr>
Codecov Report
@@ Coverage Diff @@
## main #4761 +/- ##
==========================================
+ Coverage 76.02% 76.04% +0.02%
==========================================
Files 223 223
Lines 32053 32085 +32
==========================================
+ Hits 24367 24398 +31
- Misses 7686 7687 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The CI fails because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @QRemy
Signed-off-by: <quentin.remy@live.fr>
I tried to fix that direclty in this PR but I could open an other one instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @QRemy. This looks good.
I think having the angular_utilities change in another PR would be better. But this can go as is.
This part of the PR can be backported too to ensure CI runs on bugfix branches with future versions.
…1-on-v1.0.x Backport PR #4761 on branch v1.0.x (Regenerate name to avoid starting with underscore)
…1-on-v1.1.x Backport PR #4761 on branch v1.1.x (Regenerate name to avoid starting with underscore)
Prevent a random fail in the CI when auto-generated name start with underscore :
FAILED .....tox\py310-test-alldeps_noray\lib\site-packages\gammapy\visualization\tests\test_datasets.py::test_plot_spectrum_datasets_off_regions - matplotlib._api.deprecation.MatplotlibDeprecationWarning: An artist whose label starts with an underscore was passed to legend(); such artists will no longer be ignored in the future. To suppress this warning, explicitly filter out such artists, e.g. with
[art for art in artists if not art.get_label().startswith('_')]
.This should fix the break seen in #4759.