New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license to dev folder files #4868
Conversation
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #4868 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 226 226
Lines 33069 33071 +2
=======================================
+ Hits 25007 25009 +2
Misses 8062 8062
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Astro-Kirsty
Thanks @Astro-Kirsty, If you run this small script :
|
You can actually run this script, that will do it for you !
|
@registerrier, @bkhelifi, @AtreyeeS, @adonath, do we want a script like this in the dev rep that we can run from time to time to be sure that the license is in all the files ? |
+1 for adding a script like this in the dev rep!! |
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Added the license to the rest of the files! Did not add to |
You can probably put it just after this line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty . Good point.
I assume empty files might not need a license :-) But that's fine as they might be filled later.
An option could be to include this type of check as part of the CI code checks.
This is external package. I don't think we should re-license it. |
Merging now. |
As mentioned here the dev folder did not have licenses.
This PR solves this