Adjust to_edisp_kernel input to MapAxis

[Astro-Kirsty]

This PR is to resolve #5142.
I left it as a draft as I am not sure if this is the correct procedure to take.
This is two part issue, we want to change the variables to be consistent with the other naming for axis

gammapy/gammapy/irf/edisp/map.py

Line 116 in 86488ec

def to_edisp_kernel_map(self, energy_axis):

We also need to change the variable to no longer be a quantity but a MapAxis.

This was the best way I could think to achieve this.

Note: there are a number of failing tests, but I did not want to fix them all with the deprecation warning until a method was decided upon.

I am open to suggestions.

[AtreyeeS]

Thanks @Astro-Kirsty !

I do not think you need to adapt internet tests to check for the deprecation warning, eg as done in gammapy/datasets/tests/test_map.py
It only needs to be checked when the user passes a quantity instead of a MapAxis in the to_edisp_kernel function, and internally within Gammapy we should pass a MapAxis.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (f85fb7b) to head (e8e4a7c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5186   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         232      232           
  Lines       35636    35645    +9     
=======================================
+ Hits        33664    33673    +9     
  Misses       1972     1972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[QRemy]

Thanks @Astro-Kirsty looks good.

[AtreyeeS]

Thanks @Astro-Kirsty ! No further comments

[AtreyeeS]

Please check that the deprecation works correctly, ie, the old behaviour is still supported

Added question about deprecation

[AtreyeeS]

No further comments. Thanks!

[registerrier]

Thanks @Astro-Kirsty . This looks good!