Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in new timmerkonig #5250

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

Astro-Kirsty
Copy link
Member

These are some small adaptions that didnt make it into the PR by @cgalelli before merge

Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
Copy link
Contributor

@cgalelli cgalelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @Astro-Kirsty !

Copy link
Contributor

@QRemy QRemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Astro-Kirsty, no comment from my side.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (d2ab20c) to head (50bbef6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5250   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files         234      234           
  Lines       35131    35131           
=======================================
  Hits        26442    26442           
  Misses       8689     8689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QRemy QRemy merged commit 2475a00 into gammapy:main May 7, 2024
16 of 17 checks passed
@Astro-Kirsty Astro-Kirsty deleted the lightcurve_docs branch May 14, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants