Fix setup.py and docs/conf.py configparser import #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdeil
force-pushed
the
setup-configparser
branch
from
a08b66b
to
15f21f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
ConfigParserimport insetup.pyanddocs/conf.py, which we inherited from the Astropy package template, that made installing Gammapy and building the docs fail on Python 3.5.2+.If someone cares: the issue is that in Python 3.5.2 they changed an import in the Python stdlib in
distutils.configfromConfigParsertoRawConfigParserand the Astropy package-templatesetup.pyanddocs/conf.pywas importingConfigParserfrom there (relying on an implementation detail, which it never should have done). See astropy/package-template#180