New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py and docs/conf.py configparser import #594

Merged
merged 1 commit into from Jun 28, 2016

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented Jun 28, 2016

This PR fixes an issue with ConfigParser import in setup.py and docs/conf.py, which we inherited from the Astropy package template, that made installing Gammapy and building the docs fail on Python 3.5.2+.

If someone cares: the issue is that in Python 3.5.2 they changed an import in the Python stdlib in distutils.config from ConfigParser to RawConfigParser and the Astropy package-template setup.py and docs/conf.py was importing ConfigParser from there (relying on an implementation detail, which it never should have done). See astropy/package-template#180

@cdeil cdeil added bug astropy labels Jun 28, 2016

@cdeil cdeil added this to the 0.5 milestone Jun 28, 2016

@cdeil cdeil self-assigned this Jun 28, 2016

@cdeil cdeil force-pushed the cdeil:setup-configparser branch from a08b66b to 15f21f9 Jun 28, 2016

@cdeil cdeil merged commit 71d9dd0 into gammapy:master Jun 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment