New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error methods on spectral models #985

Merged
merged 3 commits into from Apr 24, 2017

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Apr 24, 2017

This PR adds analytical solutions to xxxxx_error() methods, where available. Fixes gammapy/gamma-cat#107 and #984

@cdeil

@adonath - Thanks!

I left a few inline comments. Nothing controversial I think.

Show outdated Hide outdated gammapy/spectrum/models.py Outdated
Show outdated Hide outdated gammapy/spectrum/models.py Outdated
Show outdated Hide outdated gammapy/spectrum/models.py Outdated
Show outdated Hide outdated gammapy/spectrum/models.py Outdated

@cdeil cdeil added bug feature labels Apr 24, 2017

@cdeil cdeil self-assigned this Apr 24, 2017

@cdeil cdeil added this to the 0.6 milestone Apr 24, 2017

@cdeil

cdeil approved these changes Apr 24, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Apr 24, 2017

Member

Thanks! Merging this now.

Travis-ci fails are unrelated, I'll fix those now.

Member

cdeil commented Apr 24, 2017

Thanks! Merging this now.

Travis-ci fails are unrelated, I'll fix those now.

@cdeil cdeil merged commit e8b5a5a into gammapy:master Apr 24, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment