Improve error methods on spectral models #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdeil
suggested changes
Apr 24, 2017
gammapy/spectrum/models.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| emin : `~astropy.units.Quantity` |
There was a problem hiding this comment.
You can make it a bit shorter if you put it like this:
emin, emax : `~astropy.units.Quantity`
Energy range
gammapy/spectrum/models.py
Outdated
| emin : `~astropy.units.Quantity` | ||
| Lower bound of integration range. | ||
| emax : `~astropy.units.Quantity` | ||
| Upper bound of integration range |
There was a problem hiding this comment.
Put Returns section. Is it also a tuple?
gammapy/spectrum/models.py
Outdated
|
|
||
| val = -1 * upars['index'] + 2 | ||
|
|
||
| if np.isclose(val.n, 0): |
There was a problem hiding this comment.
Please use .nominal_value and .std_dev everywhere.
The .n and .s is really cryptic for people like me that aren't using uncertainties much.
gammapy/spectrum/models.py
Outdated
| Lower bound of integration range. | ||
| emax : `~astropy.units.Quantity` | ||
| Upper bound of integration range | ||
|
|
cdeil
approved these changes
Apr 24, 2017
|
Thanks! Merging this now. Travis-ci fails are unrelated, I'll fix those now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds analytical solutions to
xxxxx_error()methods, where available. Fixes gammapy/gamma-cat#107 and #984