Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing .todos.json from a synced list will cause crash #148

Closed
gammons opened this issue Feb 17, 2019 · 0 comments · Fixed by #205
Closed

removing .todos.json from a synced list will cause crash #148

gammons opened this issue Feb 17, 2019 · 0 comments · Fixed by #205
Labels

Comments

@gammons
Copy link
Owner

gammons commented Feb 17, 2019

synced lists cannot handle when a synced list's .todos.json is removed.

To repro:

  1. Sync a list with ultralist.io
  2. rm -rf .todos.json
  3. Run ultralist init
  4. See crash.
Repo initialized.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x72a670]

goroutine 1 [running]:
github.com/gammons/ultralist/ultralist.(*EventLogger).LoadSyncedLists(0xc420074300)
        /home/grant/code/go/src/github.com/gammons/ultralist/ultralist/event_logger.go:129 +0x1a0
github.com/gammons/ultralist/ultralist.(*App).InitializeRepo(0xc420095050)
        /home/grant/code/go/src/github.com/gammons/ultralist/ultralist/app.go:36 +0xf9
main.routeInput(0x7fffcf7071b3, 0x4, 0x7fffcf7071b3, 0x4)
        /home/grant/code/go/src/github.com/ultralist/ultralist/main.go:58 +0x791
main.main()
        /home/grant/code/go/src/github.com/ultralist/ultralist/main.go:21 +0xcf

LoadSycnedLists should have a grooming step to remove lists that no longer exist.

@gammons gammons added the bug label May 6, 2020
gammons pushed a commit that referenced this issue Jul 12, 2020
gammons added a commit that referenced this issue Jul 14, 2020
closes #148.

Co-authored-by: Grant Ammons <gammons@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant