-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help wanted: Implement using ~/.todos.json by default #31
Comments
For reference, there's been some related code and discussion in #13. |
This patch implments the new workflow mentioned in gammons#31, in which the program still tries to find a repo file in the working directory first, and it tries the global one in the home directory if no one is found. In this patch, the condition check of the existence of the repo file is done in `todolist/file_store.go` at the very early step before the input routing.
I post a PR first and need your feedback. If it is OK then I'll make the |
@NonerKao please update |
This patch implements the logic discussed at gammons#31, in which the program still tries to find a repo file in the working directory first, and it tries the global one in the home directory if no one is found.
#41 I'm sorry for the serious mistake that should have been taken care of. I follow your suggestion and do some local test, but it fails many tests. The reason is that, if the location check is made in Although the value of
I apologize again for all the inconvenience. |
I'll be getting to this today. |
Merged #42 and I am releasing 0.5.2 now. |
Per the comments of multiple users, I think we should implement this workflow:
.todos.json
exists in the current working directory..todos.json
.~/.todos.json
.Also, add documentation to the
gh-pages
branch to let users know this is how the app works.PRs welcome!
The text was updated successfully, but these errors were encountered: