Do not request string descriptor if index is 0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to a fix I made in 8397298 -- but impacts an API that only OpenMTP uses so I missed originally. Garmin devices have a 0 index for a couple string descriptors, which is valid but means it's not available - so requesting it is incorrect behavior.
|
awesome @CodyJung ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to a fix I made in 8397298 -- but impacts an API that only OpenMTP uses so I missed originally.
Garmin devices have a 0 index for a couple string descriptors, which is valid but means it's not available - so requesting it is incorrect behavior.
Part of the fix for ganeshrvel/openmtp#153