QEMU 3.1 compatibility #1342
Merged
QEMU 3.1 compatibility #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have successfully tested this PR with QEMU 3.1 and all possible option combinations. Also, live-migrations between QEMU 2.8 and QEMU 3.1 seem to work fine. This PR also demonstrates the need for a better framework to manage the QEMU command line. String concatenation/parsing is obviously too error-prone. |
Yes, this is ugly, but for the last commit, the original data is a raw string, so no way around it, even if for backwards compatibility. 3.0+ could change to store in a JSON file, and fallback to parsing, but not earlier… |
iustin
reviewed
Feb 19, 2019
apoikos
force-pushed
the
compat/qemu_3.1
branch
from
4ff3e9b
to
0a5f2be
Compare
apoikos
commented
Feb 19, 2019
-localtime was removed in QEMU 3.1, superseded by `-rtc base=localtime` which has been supported since QEMU 0.12.0. This is part of ganeti#1338. Signed-off-by: Apollon Oikonomopoulos <apoikos@dmesg.gr>
-balloon has been removed in QEMU 3.1, superseded by -device virtio-balloon. The latter has been supported since QEMU 0.12.0, so it's safe to use. This is part of ganeti#1338. Signed-off-by: Apollon Oikonomopoulos <apoikos@dmesg.gr>
Since QEMU 2.5, VNC TLS handling has been refactored using the `-object tls-creds-*` parameters. QEMU 3.1 completely removed the support for `-vnc tls`, so we need to switch to the new syntax. Note that this places a lower bound on QEMU 2.5 for those wishing to use VNC + TLS. 2.5.0 was released more than 3 years ago, so people should be using it already and it doesn't make sense to try to be backwards compatible here. This is part of ganeti#1338. Signed-off-by: Apollon Oikonomopoulos <apoikos@dmesg.gr>
-M has been marked as deprecated since 0.15.0 and will eventually be removed. Switch to -machine instead. Signed-off-by: Apollon Oikonomopoulos <apoikos@dmesg.gr>
Use _UpgradeSerializedRuntime to replace the unsupported command line arguments with their working counterparts. This will make already-running instances migrateable to 3.1, cross-version migration bugs aside. This is part of ganeti#1338. Signed-off-by: Apollon Oikonomopoulos <apoikos@dmesg.gr>
apoikos
force-pushed
the
compat/qemu_3.1
branch
from
0a5f2be
to
80262fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of options have been dropped in QEMU 3.1 and as a result KVM does not work out of the box. Fix these by converting to the new syntax. Note that for users using VNC TLS, this means a minimum QEMU version of 2.5 (released in Dec 2015).
This fixes #1338