gmetad: Add wildcard support to gmetad http query interface. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would probably make more sense to use something like '' to denote a wildcard, since "any" could easily exist as a substring in a host or cluster name. Could you amend the patch to use a '' wildcard before we merge it? |
|
Sure, I'll do that. |
The character '*' is treated as a wildcard. A query for "/*/*/metric_name" would include all metrics named "metric_name" from all hosts. This change does not affect the non-http query interface.
|
Updated. |
jbuchbinder
added a commit
that referenced
this pull request
Oct 26, 2012
gmetad: Add wildcard support to gmetad http query interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word "any" is treated as a wildcard. A query for "/any/any/metric_name" would include all metrics named "metric_name" from all hosts. This change does not affect the non-http query interface.