Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 32bit operating systems on 64bit arm hardware #302

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Add support for 32bit operating systems on 64bit arm hardware #302

merged 2 commits into from
Aug 5, 2023

Conversation

legolasbo
Copy link
Contributor

Thanks a lot for providing this ansible role. It worked great for my 32 bit raspberrypi 3b running 32 bit linux and my 64 bit Odroid running 64 bit linux.

Unfortunately it didn't result in a working golang installation on my 64 bit Raspberry Pi 4b's running 32 bit linux. The operating system would keep reporting "No such file or directory" when I tried to execute the binary. It turned out that the ansible role only looks at the hardware architecture when choosing which binary to install.

This PR changes that behaviour slightly to also look at the userspace_bits fact, which will have the value 32 on 32bit OS's and 64 on 64bit OS's.

I've tested the changed role on all my SBC's and it works like a charm.

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@freemanjp freemanjp merged commit a17f71e into gantsign:master Aug 5, 2023
12 checks passed
@freemanjp
Copy link
Member

@legolasbo thanks for the PR. You can find your enhancement in version 3.1.7 of this role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants