forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid creating partitioned topic for partition name (apache#6846)
Fixes apache#6840 Motivation Avoid creating partitioned topic for partition name Verifying this change New unit test added.
- Loading branch information
1 parent
9418e8e
commit f473d81
Showing
2 changed files
with
89 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicAutoCreationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.pulsar.broker.admin; | ||
|
||
import org.apache.pulsar.client.admin.PulsarAdminException; | ||
import org.apache.pulsar.client.api.Producer; | ||
import org.apache.pulsar.client.api.ProducerConsumerBase; | ||
import org.apache.pulsar.client.api.PulsarClientException; | ||
import org.junit.Assert; | ||
import org.testng.annotations.AfterMethod; | ||
import org.testng.annotations.BeforeMethod; | ||
import org.testng.annotations.Test; | ||
|
||
import java.util.List; | ||
import java.util.UUID; | ||
|
||
public class TopicAutoCreationTest extends ProducerConsumerBase { | ||
|
||
@Override | ||
@BeforeMethod | ||
protected void setup() throws Exception { | ||
conf.setAllowAutoTopicCreationType("partitioned"); | ||
conf.setAllowAutoTopicCreation(true); | ||
conf.setDefaultNumPartitions(3); | ||
super.internalSetup(); | ||
super.producerBaseSetup(); | ||
} | ||
|
||
@Override | ||
@AfterMethod | ||
protected void cleanup() throws Exception { | ||
super.internalCleanup(); | ||
} | ||
|
||
@Test | ||
public void testPartitionedTopicAutoCreation() throws PulsarAdminException, PulsarClientException { | ||
final String namespaceName = "my-property/my-ns"; | ||
final String topic = "persistent://" + namespaceName + "/test-partitioned-topi-auto-creation-" | ||
+ UUID.randomUUID().toString(); | ||
|
||
Producer<byte[]> producer = pulsarClient.newProducer() | ||
.topic(topic) | ||
.create(); | ||
|
||
List<String> partitionedTopics = admin.topics().getPartitionedTopicList(namespaceName); | ||
List<String> topics = admin.topics().getList(namespaceName); | ||
Assert.assertEquals(partitionedTopics.size(), 1); | ||
Assert.assertEquals(topics.size(), 3); | ||
|
||
producer.close(); | ||
for (String t : topics) { | ||
admin.topics().delete(t); | ||
} | ||
|
||
admin.topics().deletePartitionedTopic(topic); | ||
|
||
|
||
final String partition = "persistent://" + namespaceName + "/test-partitioned-topi-auto-creation-partition-0"; | ||
|
||
producer = pulsarClient.newProducer() | ||
.topic(partition) | ||
.create(); | ||
|
||
partitionedTopics = admin.topics().getPartitionedTopicList(namespaceName); | ||
topics = admin.topics().getList(namespaceName); | ||
Assert.assertEquals(partitionedTopics.size(), 0); | ||
Assert.assertEquals(topics.size(), 1); | ||
|
||
producer.close(); | ||
} | ||
} |