-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating partitioned topic for partition name #6846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
sijie,
merlimat and
jiazhai
and removed request for
merlimat and
sijie
April 29, 2020 16:32
codelipenghui
added
release/2.5.2
type/bug
The PR fixed a bug or issue reported a bug
labels
Apr 29, 2020
This looks good to me. I will hotfix this into my clusters at some point in the next few days and will confirm the fix as well. Thanks for the quick turn around! |
cdbartholomew
added a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Apr 29, 2020
jiazhai
approved these changes
Apr 30, 2020
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
Fixes apache#6840 Motivation Avoid creating partitioned topic for partition name Verifying this change New unit test added.
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
Fixes apache#6840 Motivation Avoid creating partitioned topic for partition name Verifying this change New unit test added.
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
May 7, 2020
Fixes apache#6840 Motivation Avoid creating partitioned topic for partition name Verifying this change New unit test added.
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
Fixes apache#6840 Motivation Avoid creating partitioned topic for partition name Verifying this change New unit test added.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#6840 Motivation Avoid creating partitioned topic for partition name Verifying this change New unit test added.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6840
Motivation
Avoid creating partitioned topic for partition name
Verifying this change
New unit test added.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation