Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating partitioned topic for partition name #6846

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

codelipenghui
Copy link
Contributor

Fixes #6840

Motivation

Avoid creating partitioned topic for partition name

Verifying this change

New unit test added.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: ( no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui requested review from sijie, merlimat and jiazhai and removed request for merlimat and sijie April 29, 2020 16:32
@codelipenghui codelipenghui self-assigned this Apr 29, 2020
@codelipenghui codelipenghui added release/2.5.2 type/bug The PR fixed a bug or issue reported a bug labels Apr 29, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone Apr 29, 2020
@addisonj
Copy link
Contributor

This looks good to me. I will hotfix this into my clusters at some point in the next few days and will confirm the fix as well.

Thanks for the quick turn around!

cdbartholomew added a commit to kafkaesque-io/pulsar that referenced this pull request Apr 29, 2020
@jiazhai jiazhai merged commit bb41702 into apache:master Apr 30, 2020
gaoran10 pushed a commit to gaoran10/pulsar that referenced this pull request May 5, 2020
Fixes apache#6840

Motivation
Avoid creating partitioned topic for partition name

Verifying this change
New unit test added.
gaoran10 pushed a commit to gaoran10/pulsar that referenced this pull request May 5, 2020
Fixes apache#6840

Motivation
Avoid creating partitioned topic for partition name

Verifying this change
New unit test added.
addisonj pushed a commit to instructure/pulsar that referenced this pull request May 7, 2020
Fixes apache#6840

Motivation
Avoid creating partitioned topic for partition name

Verifying this change
New unit test added.
jiazhai pushed a commit that referenced this pull request May 8, 2020
Fixes #6840

Motivation
Avoid creating partitioned topic for partition name

Verifying this change
New unit test added.
(cherry picked from commit bb41702)
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request May 27, 2020
Fixes apache#6840

Motivation
Avoid creating partitioned topic for partition name

Verifying this change
New unit test added.
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Fixes apache#6840

Motivation
Avoid creating partitioned topic for partition name

Verifying this change
New unit test added.
@codelipenghui codelipenghui deleted the fix-6840 branch May 19, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.5.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo-replication failed when enabling partitioned topic auto-creation
3 participants