Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile on Node 12 #1

Closed
pdufour opened this issue Dec 10, 2019 · 1 comment
Closed

Doesn't compile on Node 12 #1

pdufour opened this issue Dec 10, 2019 · 1 comment

Comments

@pdufour
Copy link

pdufour commented Dec 10, 2019

Hi! it seems like you have the most up to date fork of ed25519. I was looking at using this library because I'm having trouble with the native crypto resource. Unfortunately it doesn't compile on Node 12:

./src/ed25519.cc:19:89: error: no matching member function for call to 'ToObject'
        if ((info.Length() < 1) || (!Buffer::HasInstance(info[0])) || (Buffer::Length(info[0]->ToObject()) != 32)) {
@gaoxiangxyz
Copy link
Owner

you can try this which build c code to wasm. It should be working for node12 although it is not tested. And we may test it on node12 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants