Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ed25519 under Node 12 #2

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix ed25519 under Node 12 #2

merged 1 commit into from
Mar 27, 2020

Conversation

erikmav
Copy link

@erikmav erikmav commented Mar 19, 2020

  • Updated to handle object tracking changes to V8 API.
  • Fixed deprecated Object::Get() and Set() calls
  • Added Mocha as dev dependency
  • Updated test code to fix deprecated API usage

@erikmav
Copy link
Author

erikmav commented Mar 19, 2020

Fixes #1

@erikmav erikmav mentioned this pull request Mar 19, 2020
Closed
@erikmav
Fix ed25519 under Node 12
c3dc9ee 
Add Node 12 to README
@gaoxiangxyz gaoxiangxyz merged commit 6a3594a into gaoxiangxyz:master Mar 27, 2020
@erikmav erikmav mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikmav @gaoxiangxyz