Unitary #20
Merged
Unitary #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 75.22% 81.53% +6.31%
==========================================
Files 12 14 +2
Lines 1663 1950 +287
==========================================
+ Hits 1251 1590 +339
+ Misses 412 360 -52
|
Merged
fingolfin
reviewed
Sep 21, 2021
fingolfin
reviewed
Sep 28, 2021
maxhauck
force-pushed
the
mh/case-unitary
branch
from
1e1ba2c
to
b217986
Compare
ssiccha
force-pushed
the
mh/case-unitary
branch
from
c558bec
to
f26832f
Compare
maxhauck
force-pushed
the
mh/case-unitary
branch
from
f26832f
to
505b1c5
Compare
Merged
ssiccha
force-pushed
the
mh/case-unitary
branch
from
505b1c5
to
aa399ac
Compare
|
Parts of this PR were merged in via #22. The comments by @fingolfin will be adressed in this PR. |
fingolfin
reviewed
Oct 1, 2021
fingolfin
reviewed
Oct 1, 2021
Closed
ssiccha
reviewed
Oct 1, 2021
maxhauck
force-pushed
the
mh/case-unitary
branch
from
a7d28da
to
9d867d9
Compare
Closed
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage ? 83.59%
=======================================
Files ? 14
Lines ? 1981
Branches ? 0
=======================================
Hits ? 1656
Misses ? 325
Partials ? 0 |
ssiccha
force-pushed
the
mh/case-unitary
branch
2 times, most recently
from
4bba041
to
b718577
Compare
Co-authored-by: maxhauck <mahauck@rhrk.uni-kl.de>
ssiccha
force-pushed
the
mh/case-unitary
branch
from
b718577
to
807985c
Compare
ssiccha
approved these changes
Oct 5, 2021
|
DefaultFieldOfMatrixGroup is not tested here yet. This is done in #36. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All geometric subgroups of SU(d, q).
Includes the fixes in #13. Fixes #24. Fixes #15.