Prevent Z(p,d), p non-prime, from breaking the type system #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking Z(p,d) with p not a prime used to crash gap, which we fixed. However, invocations like `Z(4,5)` still would erroneously trigger the creation of a type object for fields of size p^d (in the example: 1024), with the non-prime value p set as characteristic. This could then corrupt subsequent computations. Also get rid of a stray #include
stevelinton
approved these changes
Aug 7, 2017
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
- Coverage 63.98% 63.98% -0.01%
==========================================
Files 993 993
Lines 325152 325155 +3
Branches 12994 12995 +1
==========================================
- Hits 208039 208035 -4
Misses 114323 114323
- Partials 2790 2797 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking Z(p,d) with p not a prime used to crash gap, which we fixed.
However, invocations like
Z(4,5)still would erroneously trigger thecreation of a type object for fields of size p^d (in the example: 1024),
with the non-prime value p set as characteristic. This could then corrupt
subsequent computations.
Also get rid of a stray #include.
This should resolve the error in PR #1569