Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Z(p,d), p non-prime, from breaking the type system #1573

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

fingolfin
Copy link
Member

Invoking Z(p,d) with p not a prime used to crash gap, which we fixed.
However, invocations like Z(4,5) still would erroneously trigger the
creation of a type object for fields of size p^d (in the example: 1024),
with the non-prime value p set as characteristic. This could then corrupt
subsequent computations.

Also get rid of a stray #include.

This should resolve the error in PR #1569

Invoking Z(p,d) with p not a prime used to crash gap, which we fixed.
However, invocations like `Z(4,5)` still would erroneously trigger the
creation of a type object for fields of size p^d (in the example: 1024),
with the non-prime value p set as characteristic. This could then corrupt
subsequent computations.

Also get rid of a stray #include
@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Aug 7, 2017
Copy link
Contributor

@stevelinton stevelinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@codecov
Copy link

codecov bot commented Aug 7, 2017

Codecov Report

Merging #1573 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1573      +/-   ##
==========================================
- Coverage   63.98%   63.98%   -0.01%     
==========================================
  Files         993      993              
  Lines      325152   325155       +3     
  Branches    12994    12995       +1     
==========================================
- Hits       208039   208035       -4     
  Misses     114323   114323              
- Partials     2790     2797       +7
Impacted Files Coverage Δ
src/finfield.c 86.81% <50%> (-0.49%) ⬇️
src/hpc/thread.c 46.44% <0%> (-0.4%) ⬇️
src/hpc/traverse.c 78.29% <0%> (-0.31%) ⬇️
src/stats.c 72.56% <0%> (-0.27%) ⬇️
src/funcs.c 70.83% <0%> (-0.15%) ⬇️
src/stringobj.c 77.65% <0%> (-0.13%) ⬇️
src/hpc/threadapi.c 35.12% <0%> (+0.29%) ⬆️

@fingolfin fingolfin merged commit 5a84da3 into gap-system:master Aug 7, 2017
@fingolfin fingolfin deleted the mh/fix-FFE-bug branch August 17, 2017 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants