Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NumberColumns and NumberRows to MatrixObj interface #1657

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

fingolfin
Copy link
Member

These are meant to be used instead of Length and RowLength.
We retain RowLength for now, to keep existing code (and packages!)
working, but the plan is to remove this eventually.

Also provide default implementations of both for IsMatrix.

These are meant to be used instead of Length and RowLength.
We retain RowLength for now, to keep existing code (and packages!)
working, but the plan is to remove this eventually.

Also provide default implementations of both for IsMatrix.
@olexandr-konovalov olexandr-konovalov added the gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall label Sep 4, 2017
Copy link
Contributor

@ssiccha ssiccha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Sep 4, 2017

Codecov Report

Merging #1657 into master will increase coverage by 0.17%.
The diff coverage is 17.64%.

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
+ Coverage   64.16%   64.33%   +0.17%     
==========================================
  Files        1001     1001              
  Lines      325891   326672     +781     
  Branches    13196    13211      +15     
==========================================
+ Hits       209098   210174    +1076     
- Misses     113442   113646     +204     
+ Partials     3351     2852     -499
Impacted Files Coverage Δ
lib/vec8bit.gi 48.71% <0%> (-0.43%) ⬇️
lib/matobjplist.gi 0% <0%> (ø) ⬆️
hpcgap/lib/vec8bit.gi 47.86% <0%> (-0.4%) ⬇️
lib/vecmat.gi 67.18% <0%> (-0.24%) ⬇️
hpcgap/lib/vecmat.gi 64.67% <0%> (-0.21%) ⬇️
lib/matobj.gi 9.03% <37.5%> (+0.59%) ⬆️
src/saveload.c 56.1% <0%> (-1.61%) ⬇️
src/iostream.c 45.34% <0%> (-1.3%) ⬇️
src/system.c 53.1% <0%> (-1.23%) ⬇️
src/vector.c 92.16% <0%> (-0.4%) ⬇️
... and 65 more

@fingolfin fingolfin merged commit e089bfd into gap-system:master Sep 5, 2017
@fingolfin fingolfin deleted the mh/NrRowsCols branch September 5, 2017 22:35
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants