Fix crash when returning from "method not found" break loop #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug: crash
fingolfin
requested review from
ChrisJefferson,
olexandr-konovalov and
stevelinton
This was referenced May 8, 2018
Codecov Report
@@ Coverage Diff @@
## master #2449 +/- ##
==========================================
+ Coverage 73.95% 73.95% +<.01%
==========================================
Files 484 484
Lines 245403 245403
==========================================
+ Hits 181480 181483 +3
+ Misses 63923 63920 -3
|
ChrisJefferson
approved these changes
May 8, 2018
stevelinton
approved these changes
May 8, 2018
|
Backported to stable-4.9 via b5c0c78 |
olexandr-konovalov
added
the
release notes: added
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2447
This should be backported to stable-4.9. I am not sure how far the 4.9.1 release process is -- if there is still time, we might even want to squeeze it in there. If not, then it should go into GAP 4.9.2, and we should consider documenting this as a "known regression" in GAP 4.9.1.