Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HANDLE_METHOD_NOT_FOUND to never return #2450

Merged

Conversation

fingolfin
Copy link
Member

Using return; to exit a "method not found" break loop had more or less the same effect as using quit;

This PR contains PR #2449, but the second commit in it may be more controversial (?) than the fix in the first PR; also, only that fix should be backported to stable-4.9, not the second commit in here; hence I have put this into a separate PR.q

@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #2450 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #2450      +/-   ##
==========================================
- Coverage   73.95%   73.95%   -0.01%     
==========================================
  Files         484      484              
  Lines      245403   245402       -1     
==========================================
- Hits       181482   181475       -7     
- Misses      63921    63927       +6
Impacted Files Coverage Δ
lib/methsel2.g 43.93% <100%> (ø) ⬆️
src/opers.c 94.48% <83.33%> (-0.14%) ⬇️
hpcgap/lib/hpc/stdtasks.g 63.42% <0%> (-0.77%) ⬇️
src/stats.c 87.05% <0%> (-0.14%) ⬇️

@fingolfin fingolfin force-pushed the mh/cleanup-no-method-found branch from 349d6d0 to 2836043 Compare May 9, 2018 12:35
Using `return;` to exit a "method not found" break loop had more or less the
same effect as using `quit;`
@ChrisJefferson ChrisJefferson merged commit e1148e4 into gap-system:master May 11, 2018
@fingolfin fingolfin deleted the mh/cleanup-no-method-found branch May 11, 2018 10:44
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: error handling topic: kernel topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants