Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup stacks in pc group collection code #2461

Merged
merged 3 commits into from
May 22, 2018
Merged

Cleanup stacks in pc group collection code #2461

merged 3 commits into from
May 22, 2018

Commits on May 18, 2018

  1. kernel: call InitGlobalBag(bag) before using <bag> 

    Otherwise, if a garbage collection happens after we assign a new bag to
<bag>, but before calling InitGlobalBag on it, the new bag may be garbage
collected, and we end up with a bad reference.
    @fingolfin
    fingolfin committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6a6f376 View commit details
    Browse the repository at this point in the history

  2. kernel: fix stacks for pc group collectors 

    These stacks were created as T_PLIST_EMPTY, but then used as if they were
T_STRING (but with the length field overwritten with arbitrary data), then
were resized into T_STRING.

Now they are T_DATOBJ, and we make sure not to overwrite the type slot.
    @fingolfin
    fingolfin committed May 18, 2018
    Configuration menu
    Copy the full SHA
    f591206 View commit details
    Browse the repository at this point in the history

  3. kernel: change pcp collector to use their own stacks 

    ... instead of using the stack objects in the pcp collector objects provided
by the polycyclic package. This will make it possible to remove the latter in
a future version of polycyclic, thus reducing the size of these objects
considerably.
    @fingolfin
    fingolfin committed May 18, 2018
    Configuration menu
    Copy the full SHA
    c866516 View commit details
    Browse the repository at this point in the history