Remove PositionFirstComponent #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
do not merge
Codecov Report
@@ Coverage Diff @@
## master #2791 +/- ##
==========================================
+ Coverage 85.34% 85.35% +<.01%
==========================================
Files 699 699
Lines 346504 346489 -15
==========================================
- Hits 295733 295732 -1
+ Misses 50771 50757 -14
|
|
#2789 closed - now waiting until the next AtlasRep release will be published by @ThomasBreuer and will appear in merged package archives. |
fingolfin
force-pushed
the
mh/remove-PositionFirstComponent
branch
from
a0c14b5
to
2f6365a
Compare
hulpke
approved these changes
Sep 29, 2018
50 tasks
|
Status update: this PR waits for @ThomasBreuer to publish a new release of AtlasRep, which will contain the fix as announced in #2789. |
This was referenced Nov 9, 2018
fingolfin
added
topic: packages
fingolfin
force-pushed
the
mh/remove-PositionFirstComponent
branch
from
2f6365a
to
37a8d16
Compare
|
AtlasRep release appeared, and is now in bootstrapping package archives, so we could rebase and check this and hopefully go ahead. |
fingolfin
force-pushed
the
mh/remove-PositionFirstComponent
branch
2 times, most recently
from
818597d
to
3c56de8
Compare
fingolfin
force-pushed
the
mh/remove-PositionFirstComponent
branch
from
3c56de8
to
1c7fd10
Compare
fingolfin
commented
May 29, 2019
| @@ -183,7 +183,8 @@ Here are some further name changes. | |||
|
|
|||
| <Index Key="PositionFirstComponent"><C>PositionFirstComponent</C></Index> | |||
| The operation <C>PositionFirstComponent</C> has been deprecated in GAP | |||
| 4.8 and later due to issues with its documentation and implementation. | |||
| 4.8 due to issues with its documentation and implementation, and was | |||
| removed in GAP 4.10. | |||
There was a problem hiding this comment.
We actually removed PositionFirstComponent in GAP 4.10... this Pr just removes the last vestiges of it.
fingolfin
added
release notes: not needed
|
Updated and rebased this PR. Note that |
olexandr-konovalov
approved these changes
May 29, 2019
There was a problem hiding this comment.
Looks good (in particular, https://travis-ci.org/gap-system/gap/jobs/538692593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this needs to wait till issue #2789 is resolved.