Move GAP kernel version to configure script #2873
Conversation
ChrisJefferson
added
topic: build system
release notes: to be added
There was a problem hiding this comment.
Based on what I see so far, I really think cnf/GAP-KERNEL_MAJOR_VERSION and its MINOR variant should go. Other than that, I am happy with this PR (though I worry slightly about possible confusion from the -abi string in the ARCH -- but it should be fine to revise this later on, should we feel a need, i.e., no need to hold up this PR)
| AC_SUBST([gap_kernel_minor_version]) | ||
|
|
||
| AC_DEFINE_UNQUOTED([GAP_KERNEL_MAJOR_VERSION], $gap_kernel_major_version, [The major version of the kernel ABI]) | ||
| AC_DEFINE_UNQUOTED([GAP_KERNEL_MINOR_VERSION], $gap_kernel_minor_version, [The minor version of the kernel ABI]) |
There was a problem hiding this comment.
If we do this, we might as well start using this to version the libgap shared library, by passing.Not at all saying this should be done in this PR (it's a bit tricky to get semantically right, though not much if one takes the time to read the explanations on what the arguments mean), just wanted to mention it -- we could file an issue for that idea, then somebody (possibly me) can one day look into it.
|
Oh, and overall, I think this PR is a very good idea, thank you! |
ChrisJefferson
force-pushed
the
move-kernel-version
branch
from
d87eb04
to
6c222d1
Compare
This allow the version to be used in the ABI and allow it to be more easily accessed by packages without parsing headers
ChrisJefferson
force-pushed
the
move-kernel-version
branch
from
6c222d1
to
ad6a998
Compare
wucas
added
kind: enhancement
This lifts the GAP kernel version to the configure script, so it can be used during configure and creating the Makefile. The kernel version is used in two new places:
We put it in sysinfo.gap, so it's easier for packages to get it
We put it in the build directory (so mine is now
x86_64-pc-linux-gnu-default64-abi4, note theabi4)is useful when using thee same package directory with multiple versions of GAP (which will be particularly useful in a world where more people use the new package manager...)
is useful for languages (in my case Rust) where we want to create packages and need to know the kernel version, but don't want to have to dig through C header files to find it.
There are two broad things I'm interested in:
A) Does putting something like the major kernel version in the gaparch seem like a good idea, to make it easier for GAPs to co-exist?
B) Does this seem like a sensible way to do it?