Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for GMP crash on Cygwin (regression introduced by PR #3434) #3435

Merged
merged 5 commits into from
May 4, 2019
Merged

Workaround for GMP crash on Cygwin (regression introduced by PR #3434) #3435

merged 5 commits into from
May 4, 2019

Commits on May 2, 2019

  1. Initial fix for gap-system#3434: Add ENSURE_BAG helper which ensures … 

    …memory is

really committed by the OS for a new bag.

Call ENSURE_BAG on new bags created in integer.c if they might be
passed as an argument to a GMP function.
    @embray
    embray committed May 2, 2019
    Configuration menu
    Copy the full SHA
    abd23b1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Just limit the scope of ENSURE_BAG to integer.c for now since it's th… 

    …e only known use case.
    @embray
    embray committed May 3, 2019
    Configuration menu
    Copy the full SHA
    95324a2 View commit details
    Browse the repository at this point in the history

  2. Add inline documentation for ENSURE_BAG and when/how it should be used.

    @embray
    embray committed May 3, 2019
    Configuration menu
    Copy the full SHA
    f29a42c View commit details
    Browse the repository at this point in the history

  3. Disable the workaround if gmp.h comes from MPIR, in which case __MPIR… 

    …_VERSION should be defined.
    @embray
    embray committed May 3, 2019
    Configuration menu
    Copy the full SHA
    1a6eb16 View commit details
    Browse the repository at this point in the history

  4. clang-format tweaks

    @embray
    embray committed May 3, 2019
    Configuration menu
    Copy the full SHA
    95a011a View commit details
    Browse the repository at this point in the history