Speed up printing of large permutations #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
added
kind: enhancement
fingolfin
approved these changes
Nov 13, 2019
|
Oops, needs to be rebased now |
Remove old O(n^2) algorithm with O(n) algorithm
Replace old O(n^2) algorithm with O(n) one, because unlike the comment, we are no longer limited to 9600 baud and can produce some large permutations
ChrisJefferson
force-pushed
the
fast-perm-print
branch
from
68b439a
to
b12bffe
Compare
|
Hopefully all issues fixed (once the tests cycle) |
PaulaHaehndel
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAP is very slow at printing large permutations (say on the order of 2^20), it can take several minutes. This is because it uses a silly O(n^2) algorithm.
This improves the two places where we print permutations to instead use an O(n) algorithm.