Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in option name of IsomorphismSimplifiedFpGroup #4076

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in option name of IsomorphismSimplifiedFpGroup #4076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
701621f
FIX: Infinite loop in series refinement
hulpke Jul 16, 2020
d452611
DOC: Clarifying remark on `IsAutomorphismGroup`
hulpke Jul 12, 2020
77141e7
ENHANCE: Typo in option name
hulpke Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ghomfp.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ local H, pres,map,mapi,opt;
opt:=TzOptions(pres);

if ValueOption("protected")<>fail then
opt.expandLimit:=ValueOption("protected");
opt.protected:=ValueOption("protected");
fi;

opt.printLevel:=InfoLevel(InfoFpGroup);
Expand Down
4 changes: 3 additions & 1 deletion lib/morpheus.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ DeclareAttribute( "AutomorphismDomain", IsGroupOfAutomorphisms );
## <Prop Name="IsAutomorphismGroup" Arg='G'/>
##
## <Description>
## indicates whether <A>G</A> is the full automorphism group of another
## indicates whether <A>G</A>, which must be
## <Ref Prop="IsGroupOfAutomorphisms"/>,
## is the full automorphism group of another
## group <M>H</M>, this group is given as <Ref Attr="AutomorphismDomain"/>
## value of <A>G</A>.
## <Example><![CDATA[
Expand Down
3 changes: 3 additions & 0 deletions lib/pcgs.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,6 +1557,9 @@ local pcgs,rel,gp,i,indp,inds,module,sub;
ind:=Concatenation(ind{[1..i-1]},[ind[i-1]+Length(inds)],
ind{[i..Length(ind)]});
SetIndicesChiefNormalSteps(pcgs,ind);
else
i:=i+1; # cannot do
SetIndicesChiefNormalSteps(pcgs,ind);
fi;
else
i:=i+1;
Expand Down
11 changes: 11 additions & 0 deletions tst/testbugfix/2020-07-16-BoundedRefinement.tst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Unrefinable series
gap> g:=Group((1,17)(2,18)(3,15,4,16)(5,13)(6,14)(7,11,8,12)(9,10)
> (19,45,20,46)(21,43,22,44)(23,42)(24,41)(25,40)(26,39)(27,38,28,37)
> (29,36)(30,35)(31,33,32,34),
> (1,29,12,40,22,3,32,14,42,24,6,34,15,44,26,8,36,17,45,28,10,38,19)(2,30,11,
> 39,21,4,31,13,41,23,5,33,16,43,25,7,35,18,46,27,9,37,20));;
gap> home:=HomePcgs(g);;
gap> ind:=IndicesEANormalStepsBounded(home,2^15);;
gap> BoundedRefinementEANormalSeries(home,ind,2^15);;
gap> List(ChiefNormalSeriesByPcgs(home),Size);
[ 192937984, 96468992, 4194304, 1 ]