Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for subgroup conjugacy for cyclic permutation groups (If A,B are cyclic conjugate subgroups of G, and A <= C, with C abelian, the error could have caused a claim of C being conjugate to B) #4634

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix test for subgroup conjugacy for cyclic permutation groups (If A,B are cyclic conjugate subgroups of G, and A <= C, with C abelian, the error could have caused a claim of C being conjugate to B) #4634

merged 1 commit into from
Aug 23, 2021

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Aug 22, 2021

This fixes a bug reported by M. Dutour in a forum mail on 8/22/21

If A,B\le G are cyclic and conjugate in G, and A\le C, C abelian, the error could have caused a claim of C being conjugate to B.

@hulpke
FIX: Condition for cyclic conjugacy
e225d9f 
This fixes a bug reported by M. Dutour in a foum mail on 8/22/21
@hulpke hulpke added kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them backport-to-4.11 labels Aug 22, 2021
@ChrisJefferson ChrisJefferson merged commit 6bb5d1d into gap-system:master Aug 23, 2021
@fingolfin fingolfin changed the title FIX: subgroup conjugacy for cyclic permutation groups Fix test for subgroup conjugacy for cyclic permutation groups Aug 17, 2022
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed backport-to-4.11 labels Aug 17, 2022
@fingolfin fingolfin changed the title Fix test for subgroup conjugacy for cyclic permutation groups Fix test for subgroup conjugacy for cyclic permutation groups (If A,B <= G are cyclic and conjugate in G, and A <= C, with C abelian, the error could have caused a claim of C being conjugate to B) Aug 17, 2022
@fingolfin fingolfin changed the title Fix test for subgroup conjugacy for cyclic permutation groups (If A,B <= G are cyclic and conjugate in G, and A <= C, with C abelian, the error could have caused a claim of C being conjugate to B) Fix test for subgroup conjugacy for cyclic permutation groups (If A,B are cyclic conjugate subgroups of G, and A <= C, with C abelian, the error could have caused a claim of C being conjugate to B) Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hulpke @fingolfin @ChrisJefferson