Fix bug in computing canonical class representative for pc groups which could yield wrong results in larger groups #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
must always use the same series. So if refining, cache result. This unfortunately only is triggered in larger examples (i.e. when refining happens).
hulpke
added
kind: bug: wrong result
fingolfin
approved these changes
Mar 10, 2022
fingolfin
changed the title
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must always use the same series. So if refining, cache result.
This unfortunately only is triggered in larger examples (i.e. when refining
happens). The only reproduceable test I have is in a somewhat larger group and runs for about half an hour.
Text for release notes
An error in computing canonical conjugacy class representatives, that could yield wrong results in larger groups, has been fixed.