Fix unexpected error in ConjugacyClassesSubgroups
#5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables an attempt to use cyclic extension instead of lifting for lattices of smallish groups. The issue is that CE returns data in a slightly different format than required. This resulted in some commands, e.g. `ConjugacyClassesSubgroups(SmallGroup(1344,11293))`, to enter a break loop. If tomlib is loded it's a mote issue, and thus does not merit further investigation. This resolves gap-system#4854
fingolfin
added
kind: bug
danielrademacher
approved these changes
Sep 7, 2022
|
Backported to stable-4.12 via e2a206e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables an attempt to use cyclic extension instead of lifting for
lattices of smallish groups. The issue is that CE returns data in a
slightly different format than required. This resulted in some commands,
e.g.
ConjugacyClassesSubgroups(SmallGroup(1344,11293)), to enter abreak loop.
If tomlib is loded it's a mote issue, and thus does not merit further
investigation.
This resolves #4854
This patch is taken from @hulpke's PR #5031 (but with a test case added and a code comment explaining what's going on). Having different, unrelated improvements and bug fixes on separate PRs reduces the work needed to make GAP releases quite a bit (as it allows us to deal with those PRs in automation, instead of adding them to the list of PRs that need manual work), and is also more convenient for reviewers, so I am splitting it off here.