Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernel method for 'Remove' with one argument #766

Merged
merged 2 commits into from
Apr 29, 2016

Conversation

frankluebeck
Copy link
Member

This fixes the following problem (reported to the support list):
gap> L:=[1,2,,,3];
[ 1, 2,,, 3 ]
gap> Remove(L);
3
gap> L;
[ 1, 2,, ]

that is, the length was not reduced to the position of the last bound entry.

This fixes the following problem (reported to the support list):
gap> L:=[1,2,,,3];
[ 1, 2,,, 3 ]
gap> Remove(L);
3
gap> L;
[ 1, 2,, ]

that is, the length was not reduced to the position of the last bound entry.
@ChrisJefferson
Copy link
Contributor

This looks good. Perhaps add a test for the list becoming empty, just to make sure it's right (I'm sure it is, but doesn't hurt to check!)

@frankluebeck
Copy link
Member Author

Of course, I had done some more tests before. I have now added a few more lines to bugfix.tst.

@markuspf
Copy link
Member

Thanks for fixing this!

@markuspf markuspf merged commit cd4afab into gap-system:master Apr 29, 2016
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone May 10, 2016
@olexandr-konovalov
Copy link
Member

@frankluebeck @markuspf Thanks! I think this also should be cherry-picked onto stable-4.8.

@markuspf
Copy link
Member

markuspf commented May 10, 2016

I just cherry-picked it, but the merge back into master duplicated the commits. ugly.

@olexandr-konovalov
Copy link
Member

Thanks - then changing milestone to 4.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants