Powerful p-Groups Feature #894
Conversation
…s commit I have included tests, which in particular test the true methods for abelian p-groups, test that powerfulness is inherited to quotient groups, that the function works for 2-groups and odd p groups. Documentation is improved. As computing IsPowerfulPGroup will involve computing the agemos, I have installed a high priority method for finding the frattini subgroup of powerful p-groups, in the case that G is a group which is powerful and with computed agemos, which will almost always be the case if IsPowerfulPGroup has been called, then GAP now just returns Agemo(G,p) instead of computing FrattiniSubgroup(G).
| <#Include Label="PrimePGroup"> | ||
| <#Include Label="PClassPGroup"> | ||
| <#Include Label="RankPGroup"> | ||
| <#Include Label="IsPSolvable"> | ||
| <#Include Label="IsPNilpotent"> | ||
|
|
||
|
|
There was a problem hiding this comment.
Try to avoid random whitespace changes (I know it's annoying to do so)
|
I don't really like the |
|
Don't worry about the problems github is reporting about 'conflicts'. Basically you, and someone else, added a test to prgroups.tst. The solution is probably to 'rebase' your code, but if you aren't happy doing that (it can be a little tricky if you aren't happy with git), then one of us can do it later. |
…t case. Also removed white space at end of groups.xml . This is as per the suggestions.
|
Hi @ChrisJefferson , |
olexandr-konovalov
added
the
release notes: added
Please make sure that this pull request:
Description of changes (for the release notes)
This feature adds the property
IsPowerfulPGroupfor groups, and the methodIsPowerfulPGroup(G).A finite p-group G is said to be a Powerful p-group if the commutator subgroup [G,G] is contained in
G^{p} if the prime p is odd, or if [G,G] is contained in G^{4} if p=2.
In the case a p- group is powerful, then FrattiniSubgroup(G)=G^{p} . Therefore, if GAP knows a group is powerful and has the computed Agemos (which is most likely the case if it has tested if G is powerful), then using this feature it can quickly return the FrattiniSubgroup without doing any extra work.
This is my first time uploading a GAP feature, I hope everything seems okay.
(Note: For more details on Powerful p-Groups, see:
Powerful p-groups. I. Finite groups, Alexander Lubotzky, Avinoam Mann )