Fix doctests

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

Doctests were not executed.

Issue Number: N/A

What is the new behavior?

Doctests are executed. Although I think a bunch of them should move to unit tests, since they have little value for (new) users.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[danyeaw]

Great idea! Did you see that Python 3.6 and 3.7 are causing a seg fault?

[amolenaar]

Not yet. But that's why I tried it on a branch first 😊

[danyeaw]

@amolenaar I made some updates to match the tox/build config from the generic repo, and I fixed an issue setting the strength of a Variable instance. We are getting a seg fault still on the CI, any ideas?

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.08%.

Quality metrics	Before	After	Change
Complexity	1.00 ⭐	0.99 ⭐	-0.01 👍
Method Length	31.87 ⭐	31.71 ⭐	-0.16 👍
Working memory	5.30 ⭐	5.28 ⭐	-0.02 👍
Quality	89.75% ⭐	89.83% ⭐	0.08% 👍

Other metrics	Before	After	Change
Lines	1440	1443	3

Changed files	Quality Before	Quality After	Quality Change
gaphas/geometry.py	77.95% ⭐	77.96% ⭐	0.01% 👍
gaphas/item.py	91.49% ⭐	91.49% ⭐	0.00%
gaphas/matrix.py	93.63% ⭐	93.63% ⭐	0.00%
gaphas/table.py	74.43% 🙂	74.43% 🙂	0.00%
gaphas/solver/variable.py	95.95% ⭐	96.06% ⭐	0.11% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gaphas/geometry.py	intersect_line_line	15 🙂	247 ⛔	15 😞	33.49% 😞	Try splitting into smaller methods. Extract out complex expressions
gaphas/geometry.py	point_on_rectangle	19 😞	142 😞	11 😞	44.71% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gaphas/item.py	Line._update_orthogonal_constraints	11 🙂	142 😞	12 😞	49.54% 😞	Try splitting into smaller methods. Extract out complex expressions
gaphas/table.py	Table.query	7 ⭐	171 😞	11 😞	52.04% 🙂	Try splitting into smaller methods. Extract out complex expressions
gaphas/item.py	Element.__init__	0	166 😞	13 😞	56.11% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.