Fix the view to origin #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent surprising scroll behavior, since (0, 0) is always in the view bounding box. The canvas can grow by moving items further away from the origin, but origin remains the anchor point. Also, origin is put in the upper left when opening a diagram.
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 5.19%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the view is "dynamic". It's supposed to have no origin, only elements on it. However, when opening a diagram, it always shows (0, 0) as the upper-left corner.
Issue Number: gaphor/gaphor#1004
What is the new behavior?
The origin (0, 0) is always taken into account when calculating the bounding box for the viewed content (in view coordinates).
Does this PR introduce a breaking change?
Other information