-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw guides for line handles #352
Conversation
No need for a special HandleMove mixin class.
ff12bc0
to
30fedab
Compare
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.36%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When moving a line end (a handle), no guides are created to help align the line end.
Issue Number: gaphor/gaphor#1006
What is the new behavior?
Handles are aligned with element. Line handles are also aligned with their own handles, so it's easier to make a line horizontal or vertical, without enabling the "orthogonal" setting.
Does this PR introduce a breaking change?
Other information